COMPAT: 32-bit skips #15776
Merged
COMPAT: 32-bit skips #15776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
32bit
jreback
commented
Mar 22, 2017
| @@ -648,7 +648,9 @@ def test_value_counts_uint64(self): | |||
| expected = Series([1, 1], index=[-1, 2**63]) | |||
| result = algos.value_counts(arr) | |||
|
|
|||
| tm.assert_series_equal(result, expected) | |||
| # 32-bit linux has a different ordering | |||
There was a problem hiding this comment.
@gfyoung FYI it seems we have another skip on 32-bit in here as well, so not specific to uint64. I think there is a n issue somewhere. but pretty hard to debug.
There was a problem hiding this comment.
This is indicative of a flakiness, but I'm not sure how to secure proper ordering in this case. I would hate to skip just because we can't ordering right, but I don't see how at this point.
Codecov Report
@@ Coverage Diff @@
## master #15776 +/- ##
==========================================
- Coverage 91.01% 91% -0.02%
==========================================
Files 143 143
Lines 49403 49403
==========================================
- Hits 44966 44958 -8
- Misses 4437 4445 +8
Continue to review full report at Codecov.
|
mattip
pushed a commit
to mattip/pandas
that referenced
this pull request
Apr 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14183